Doc: C API: Delete claim that PyObject_Init is GC-aware
#126418
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell, `PyObject_Init` never tells the garbage collector about the memory even if the `Py_TPFLAGS_HAVE_GC` flag is set.
bedevere-app
bot
added
docs
ZeroIntensity
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Good catch! This is an old remnant of Python 2, and hasn't been true for uh... 23 years.
ZeroIntensity
added
skip issue
needs backport to 3.12
kumaraditya303
approved these changes
Nov 5, 2024
|
Thanks @rhansen for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 5, 2024
…26418) (cherry picked from commit 407c036) Co-authored-by: Richard Hansen <[email protected]>
|
GH-126431 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 5, 2024
…26418) (cherry picked from commit 407c036) Co-authored-by: Richard Hansen <[email protected]>
|
GH-126432 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 5, 2024
…126418) (#126431) Doc: C API: Delete claim that `PyObject_Init` is GC-aware (GH-126418) (cherry picked from commit 407c036) Co-authored-by: Richard Hansen <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 5, 2024
…126418) (#126432) Doc: C API: Delete claim that `PyObject_Init` is GC-aware (GH-126418) (cherry picked from commit 407c036) Co-authored-by: Richard Hansen <[email protected]>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
PyObject_Initnever tells the garbage collector about the memory even if thePy_TPFLAGS_HAVE_GCflag is set.📚 Documentation preview 📚: https://cpython-previews--126418.org.readthedocs.build/